sarankk commented on code in PR #165: URL: https://github.com/apache/cassandra-sidecar/pull/165#discussion_r1903134693
########## server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/SidecarPermissions.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.acl.authorization; + +/** + * Sidecar permissions allowed on specific targets are listed here. Majority of sidecar permissions are represented in + * format <action_allowed>:<action_target>. + * <p> + * Example, with CREATE:SNAPSHOT permission, CREATE action is allowed for SNAPSHOT target. Sample actions are + * CREATE, VIEW, UPDATE, DELETE, STREAM, IMPORT, UPLOAD, START, ABORT etc. + * <p> + * Wildcard permissions are supported with ':' wildcard parts divider and '*' wildcard token to match parts: + * <p> + * - *:SNAPSHOT allows CREATE:SNAPSHOT, VIEW:SNAPSHOT and DELETE:SNAPSHOT. + * - CREATE:* allows CREATE action on all possible targets. + * - *:* allows all possible permissions for specified resource + */ +public class SidecarPermissions +{ + // cassandra cluster related permissions + public static final Permission VIEW_CLUSTER = new WildcardPermission("VIEW:CLUSTER"); + + // SSTable related permissions + public static final Permission UPLOAD_SSTABLE = new WildcardPermission("UPLOAD:SSTABLE"); + public static final Permission IMPORT_SSTABLE = new WildcardPermission("IMPORT:SSTABLE"); + public static final Permission STREAM_SSTABLE = new WildcardPermission("STREAM:SSTABLE"); + + // Upload related permissions + public static final Permission DELETE_SSTABLE_UPLOAD = new WildcardPermission("DELETE:SSTABLE_UPLOAD"); + + // snapshot related permissions + public static final Permission CREATE_SNAPSHOT = new WildcardPermission("CREATE:SNAPSHOT"); + public static final Permission VIEW_SNAPSHOT = new WildcardPermission("VIEW:SNAPSHOT"); + public static final Permission DELETE_SNAPSHOT = new WildcardPermission("DELETE:SNAPSHOT"); + + // restore related permissions + public static final Permission CREATE_RESTORE_JOB = new WildcardPermission("CREATE:RESTORE_JOB"); + public static final Permission VIEW_RESTORE_JOB = new WildcardPermission("VIEW:RESTORE_JOB"); + public static final Permission UPDATE_RESTORE_JOB = new WildcardPermission("UPDATE:RESTORE_JOB"); + public static final Permission ABORT_RESTORE_JOB = new WildcardPermission("ABORT:RESTORE_JOB"); Review Comment: Makes sense, will update it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org