netudima commented on code in PR #3764: URL: https://github.com/apache/cassandra/pull/3764#discussion_r1905533944
########## src/java/org/apache/cassandra/utils/FastByteOperations.java: ########## @@ -70,6 +70,21 @@ public static int compareUnsigned(ByteBuffer b1, ByteBuffer b2) return BestHolder.BEST.compare(b1, b2); } + public static int compareUnsigned(ByteBuffer b1, long address2, int length2) Review Comment: good point, I will change the naming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org