bbotella commented on code in PR #3780:
URL: https://github.com/apache/cassandra/pull/3780#discussion_r1907274086
##########
pylib/cqlshlib/cql3handling.py:
##########
@@ -756,13 +758,35 @@ def working_on_keyspace(ctxt):
<selector> ::= [colname]=<cident> ( "[" ( <term> ( ".." <term> "]" )? | <term>
".." ) )?
| <udtSubfieldSelection>
| "WRITETIME" "(" [colname]=<cident> ")"
- | "MAXWRITETIME" "(" [colname]=<cident> ")"
+ | "MAX_WRITETIME" "(" [colname]=<cident> ")"
+ | "MIN_WRITETIME" "(" [colname]=<cident> ")"
| "TTL" "(" [colname]=<cident> ")"
- | "COUNT" "(" star=( "*" | "1" ) ")"
+ | <aggregateMathFunction>
+ | <scalarMathFunction>
+ | "TO_DATE" "(" [colname]=<cident> ")"
+ | "TO_TIMESTAMP" "(" [colname]=<cident> ")"
+ | "TO_UNIX_TIMESTAMP" "(" [colname]=<cident> ")"
+ | "TOKEN" "(" [colname]=<cident> ")"
+ | "MAP_KEYS" "(" [colname]=<cident> ")"
+ | "MAP_VALUES" "(" [colname]=<cident> ")"
+ | "MIN_TIMEUUID" "(" [colname]=<cident> ")"
+ | "MAX_TIMEUUID" "(" [colname]=<cident> ")"
| "CAST" "(" <selector> "AS" <storageType> ")"
+ | "COLLECTION_AVG" "(" [colname]=<cident> ")"
+ | "COLLECTION_COUNT" "(" [colname]=<cident> ")"
+ | "COLLECTION_MIN" "(" [colname]=<cident> ")"
+ | "COLLECTION_MAX" "(" [colname]=<cident> ")"
+ | "COLLECTION_SUM" "(" [colname]=<cident> ")"
+ | "MASK_NULL" "(" [colname]=<cident> ")"
+ | "MASK_DEFAULT" "(" [colname]=<cident> ")"
+ | "MASK_REPLACE" "(" [colname]=<cident> "," <term> ")"
+ | "MASK_HASH" "(" [colname]=<cident> ")"
+ | "MASK_INNER" "(" [colname]=<cident> ")"
+ | "MASK_OUTER" "(" [colname]=<cident> ")"
Review Comment:
What do you think about extracting these to something like `maskFunction`
just like we do for `aggregateMathFunction` and `scalarMathFunction`? Similar
thing would apply to collection functions and maybe time functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
