belliottsmith commented on code in PR #155:
URL: https://github.com/apache/cassandra-accord/pull/155#discussion_r1908461141
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -693,7 +758,15 @@ protected <O> AsyncChain<O> mapReduce(PreLoadContext
context, MapReduce<? super
public synchronized Supplier<EpochReady> updateTopology(Node node,
Topology newTopology, boolean startSync)
{
TopologyUpdate update = updateTopology(node, current, newTopology,
startSync);
- current = update.snapshot;
+ // TODO (review/discussion): an alternative to this would be to store
all previous topology updates (or base compacted image + updates),
+ // and compact them into a single record. This can be done either
in this patch or in a follow-up.
+ if (update.snapshot != current)
+ {
+ AsyncResults.SettableResult<Void> flush = new
AsyncResults.SettableResult<>();
Review Comment:
as discussed, let's chain the EpochReady AsyncResult fields to complete
after this flush
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
