belliottsmith commented on code in PR #154:
URL: https://github.com/apache/cassandra-accord/pull/154#discussion_r1915010833
##########
accord-core/src/main/java/accord/local/cfk/Utils.java:
##########
@@ -261,6 +262,28 @@ static TxnId[] removePrunedAdditions(TxnId[] additions,
int additionCount, TxnId
return prunedIds;
}
+ static TxnId[] removeUnmanaged(TxnId[] ids)
+ {
+ int count = 0;
Review Comment:
Hmm, actually no I think the current approach is optimal in the case we
expect it to be mostly managed, as we don't copy anything if we don't remove
anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
