smiklosovic commented on code in PR #3562: URL: https://github.com/apache/cassandra/pull/3562#discussion_r1916589953
########## src/java/org/apache/cassandra/cql3/Json.java: ########## @@ -323,4 +363,67 @@ static Map<ColumnIdentifier, Term> parseJson(String jsonString, Collection<Colum throw new InvalidRequestException(exc.getMessage()); } } + + static Term.Raw getUnpreparedTerm(ColumnSpecification spec, Object parsedJsonObject) + { + if (spec.type instanceof NumberType) Review Comment: this can be "spec.type.isNumber()" ? Similarly for StringType, `.isString()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org