frankgh commented on code in PR #172:
URL: https://github.com/apache/cassandra-sidecar/pull/172#discussion_r1917270497
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/CacheConfigurationImpl.java:
##########
@@ -41,34 +46,57 @@ public class CacheConfigurationImpl implements
CacheConfiguration
@JsonProperty("warmup_retries")
protected final int warmupRetries;
- @JsonProperty("warmup_retry_interval_millis")
- protected final long warmupRetryIntervalMillis;
+ protected MillisecondBoundConfiguration warmupRetryInterval;
public CacheConfigurationImpl()
{
- this(TimeUnit.HOURS.toMillis(1), 100, true, 5, 1000);
+ this(MillisecondBoundConfiguration.parse("1h"), 100, true, 5,
MillisecondBoundConfiguration.parse("60s"));
Review Comment:
good catch
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/CacheConfigurationImpl.java:
##########
@@ -41,34 +46,57 @@ public class CacheConfigurationImpl implements
CacheConfiguration
@JsonProperty("warmup_retries")
protected final int warmupRetries;
- @JsonProperty("warmup_retry_interval_millis")
- protected final long warmupRetryIntervalMillis;
+ protected MillisecondBoundConfiguration warmupRetryInterval;
public CacheConfigurationImpl()
{
- this(TimeUnit.HOURS.toMillis(1), 100, true, 5, 1000);
+ this(MillisecondBoundConfiguration.parse("1h"), 100, true, 5,
MillisecondBoundConfiguration.parse("60s"));
}
@VisibleForTesting
- public CacheConfigurationImpl(long expireAfterAccessMillis, long
maximumSize)
+ public CacheConfigurationImpl(MillisecondBoundConfiguration
expireAfterAccess, long maximumSize)
{
- this(expireAfterAccessMillis, maximumSize, true, 5, 1000);
+ this(expireAfterAccess, maximumSize, true, 5,
MillisecondBoundConfiguration.parse("60s"));
Review Comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
