Maxwell-Guo commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1917610173
##########
src/java/org/apache/cassandra/cql3/Json.java:
##########
@@ -323,4 +361,67 @@ static Map<ColumnIdentifier, Term> parseJson(String
jsonString, Collection<Colum
throw new InvalidRequestException(exc.getMessage());
}
}
+
+ static Term.Raw getUnpreparedTerm(ColumnSpecification spec, Object
parsedJsonObject)
+ {
+ if (spec.type.isNumber())
+ return
Constants.Literal.floatingPoint(parsedJsonObject.toString());
+ if (spec.type.isString())
+ return Constants.Literal.string(parsedJsonObject.toString());
+ return null;
+ }
+
+ static Map<ColumnIdentifier, Term.Raw> parseUnpreparedJson(String
jsonString, Collection<ColumnMetadata> expectedReceivers)
+ {
+ try
+ {
+ Map<String, Object> valueMap =
JsonUtils.JSON_OBJECT_MAPPER.readValue(jsonString, Map.class);
Review Comment:
we can just use this function , right ?
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/JsonUtils.java#L127
##########
src/java/org/apache/cassandra/cql3/constraints/ColumnConstraint.java:
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3.constraints;
+
+import org.apache.cassandra.cql3.CqlBuilder;
+import org.apache.cassandra.db.marshal.AbstractType;
+import org.apache.cassandra.io.IVersionedSerializer;
+import org.apache.cassandra.schema.ColumnMetadata;
+
+/**
+ * Common class for the conditions that a CQL Constraint needs to implement to
be integrated in the
+ * CQL Constraints framework.
+ */
+public interface ColumnConstraint<T>
+{
+
+ // Enum containing all the possible constraint serializers to help with
serialization/deserialization
+ // of constraints.
+ public enum ConstraintType
+ {
+ // The order of that enum matters!!
Review Comment:
What effect does the order of enumeration have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
