SiyaoIsHiding commented on code in PR #1952:
URL:
https://github.com/apache/cassandra-java-driver/pull/1952#discussion_r1919679756
##########
core/src/main/java/com/datastax/oss/driver/api/core/type/DataTypes.java:
##########
@@ -69,12 +66,21 @@ public static DataType custom(@NonNull String className) {
/* Vector support is currently implemented as a custom type but is also
parameterized */
if (className.startsWith(DefaultVectorType.VECTOR_CLASS_NAME)) {
- List<String> params =
- paramSplitter.splitToList(
- className.substring(
- DefaultVectorType.VECTOR_CLASS_NAME.length() + 1,
className.length() - 1));
- DataType subType = classNameParser.parse(params.get(0),
AttachmentPoint.NONE);
- int dimensions = Integer.parseInt(params.get(1));
+ String paramsString =
Review Comment:
`paramSplitter` does not work for cases like `vector<vector<float,2>,2>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
