iamaleksey commented on code in PR #3743:
URL: https://github.com/apache/cassandra/pull/3743#discussion_r1920076395
##########
src/java/org/apache/cassandra/journal/SegmentCompactor.java:
##########
@@ -30,5 +31,7 @@ static <K, V> SegmentCompactor<K, V> noop()
return (SegmentCompactor<K, V>) NOOP;
}
+ //TODO (review): org.apache.cassandra.journal.Compactor.run documents that
this is nullable but no implementation returns null.... If we want to keep
nullable I put it in the interface so you have to check, but if we want to
remove I can go clean that assumption up.
Review Comment:
Doesn't matter much - can adjust when another implementation comes around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
