dcapwell commented on code in PR #3809:
URL: https://github.com/apache/cassandra/pull/3809#discussion_r1920648688


##########
test/distributed/org/apache/cassandra/distributed/test/log/ForceSnapshotTest.java:
##########
@@ -147,6 +148,18 @@ public void testDumpLoadMetadata() throws IOException
                     throw new RuntimeException(e);
                 }
             });
+            long epoch = cluster.get(1).callOnInstance(() -> 
ClusterMetadata.current().epoch.getEpoch());
+            cluster.forEach(i -> i.runOnInstance(() -> {

Review Comment:
   im ok if you want to do this but why not use 
`org.apache.cassandra.distributed.shared.ClusterUtils#waitForCMSToQuiesce(org.apache.cassandra.distributed.api.ICluster<org.apache.cassandra.distributed.api.IInvokableInstance>,
 org.apache.cassandra.tcm.Epoch, boolean, int...)`?
   
   with `fetchLogWhenBehind=true` you get the same behavior



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to