yifan-c commented on code in PR #171:
URL: https://github.com/apache/cassandra-sidecar/pull/171#discussion_r1928060470
##########
server/src/test/java/org/apache/cassandra/sidecar/restore/RingTopologyRefresherTest.java:
##########
@@ -141,10 +157,65 @@ void testLoadAndGetMapping()
Future<TokenRangeReplicasResponse> future =
replicaByTokenRangePerKeyspace.futureOf(job);
assertThat(future.isComplete()).isFalse();
assertThat(replicaByTokenRangePerKeyspace.forRestoreJob(job)).isNull();
+ assertThat(listenerValueCaptor).isEmpty();
TokenRangeReplicasResponse mockTopology =
mock(TokenRangeReplicasResponse.class);
replicaByTokenRangePerKeyspace.load(ks -> mockTopology);
assertThat(future.isComplete()).isTrue();
assertThat(future.result()).isSameAs(mockTopology);
assertThat(replicaByTokenRangePerKeyspace.forRestoreJob(job)).isSameAs(mockTopology);
+ assertThat(listenerValueCaptor).hasSize(1);
+ assertListenerCapturedValues(listenerValueCaptor.get(0),
job.keyspaceName, null, mockTopology);
+ }
+
+ @Test
+ void testTopologyChanged()
+ {
+ assertThat(listenerValueCaptor).isEmpty();
+ RestoreJob job = RestoreJobTest.createNewTestingJob(UUIDs.timeBased());
+ replicaByTokenRangePerKeyspace.futureOf(job);
+ TokenRangeReplicasResponse mockTopologyEpoch1 =
mock(TokenRangeReplicasResponse.class);
+ when(mockTopologyEpoch1.writeReplicas())
+ .thenReturn(Collections.singletonList(new
TokenRangeReplicasResponse.ReplicaInfo("1", "10", null)));
+ replicaByTokenRangePerKeyspace.load(ks -> mockTopologyEpoch1);
+ assertThat(listenerValueCaptor).hasSize(1);
+ assertListenerCapturedValues(listenerValueCaptor.get(0),
job.keyspaceName, null, mockTopologyEpoch1);
+ TokenRangeReplicasResponse mockTopologyEpoch2 =
mock(TokenRangeReplicasResponse.class);
+ when(mockTopologyEpoch1.writeReplicas())
+ .thenReturn(Collections.singletonList(new
TokenRangeReplicasResponse.ReplicaInfo("100", "110", null)));
+ replicaByTokenRangePerKeyspace.load(ks -> mockTopologyEpoch2);
+ assertThat(listenerValueCaptor).hasSize(2);
+ assertListenerCapturedValues(listenerValueCaptor.get(1),
job.keyspaceName, mockTopologyEpoch1, mockTopologyEpoch2);
+ }
+
+ @Test
+ void testMergeTokenRanges()
+ {
+ List<Set<TokenRange>> testAndResults = Arrays.asList(
+ // Test set, Result set
+// ImmutableSet.of(r(1, 10)), ImmutableSet.of(r(1, 10)),
+ ImmutableSet.of(r(1, 10), r(11, 20)), ImmutableSet.of(r(1, 10), r(11,
20)),
+ ImmutableSet.of(r(1, 10), r(10, 20)), ImmutableSet.of(r(1, 20)),
+ ImmutableSet.of(r(1, 10), r(5, 20)), ImmutableSet.of(r(1, 20)),
+ ImmutableSet.of(r(1, 10), r(5, 20), r(25, 30)), ImmutableSet.of(r(1,
20), r(25, 30)),
+ ImmutableSet.of(r(1, 4), r(5, 20), r(15, 30)), ImmutableSet.of(r(1,
4), r(5, 30))
+ );
+ for (int i = 0; i < testAndResults.size(); i += 2)
+ {
+
assertThat(RingTopologyRefresher.mergeTokenRanges(testAndResults.get(i))).isEqualTo(testAndResults.get(i
+ 1));
+ }
+ }
Review Comment:
ok. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
