testisnullus commented on code in PR #1836: URL: https://github.com/apache/cassandra-gocql-driver/pull/1836#discussion_r1928338909
########## host_source.go: ########## @@ -56,6 +56,7 @@ const ( type cassVersion struct { Major, Minor, Patch int + AdditionalNotation string Review Comment: In Cassandra (and many Java-based projects), the bit after the dash is often called a qualifier or sometimes a suffix. In semantic versioning, it might be part of a pre-release segment or a build meta after a plus sign. However, Cassandra uses variations like snapshot, rc, etc., which are typically called qualifiers. So, I suggest changing the name of the AdditionalNotation field to the Qualifier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org