jmckenzie-dev commented on PR #3562: URL: https://github.com/apache/cassandra/pull/3562#issuecomment-2613220127
> hello, @bbotella , do you think we need to add some test for DescribeStatementTest to see if the out put of the describe table is what we need ? Besides, Do we need cqlsh to support the ability to automatically complete the corresponding keywords for constraints and add the corresponding unit test? like [here](https://github.com/apache/cassandra/commit/46ef00a31594312403e8b42e66ae9354e7bf87ef#diff-2a60598dcb20f6075ab3bc1552b9908b20404f3d19aa7f3fcede0f4ffd15923aR1308) . @smiklosovic @jmckenzie-dev WDYT ? I know there's some on the project that would advocate for adding a test to ensure the output of DESCRIBE TABLE meets some very ultra-specific string output for every given new feature or change. I've never been too convinced of the necessity of that, but adding something to `DescribeStatementTest.java` to cover the constraint output case would cover it if you want to. Honestly, we probably _should_ do things like that and this is something I just need to come around on. I find those kinds of tests a real slog to both write and to debug (just annoying nit-picky string formatting stuff that snapshots the state of things at a moment in time, etc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
