dcapwell commented on code in PR #3835:
URL: https://github.com/apache/cassandra/pull/3835#discussion_r1931174809
##########
test/distributed/org/apache/cassandra/fuzz/snapshots/SnapshotsTest.java:
##########
@@ -132,21 +132,21 @@ private Pair<SnapshotsHolder, Map<String, String>>
generateParams()
case 1:
if (!state.truncatedSnapshots.isEmpty())
{
- keyspace =
state.rs.pick(state.truncatedSnapshots.keySet()).split("\\.")[0];
+ keyspace =
state.rs.pickUnorderedSet(state.truncatedSnapshots.keySet()).split("\\.")[0];
Review Comment:
in pulling all the `RandomSource` in this method got renamed to be 2
different methods
`pickUnorderedSet` and `pickOrderedSet`... unorded needs the sub type to be
`Comparable` and will do a sort so the result is deterministic...
`pickOrderedSet` doesn't sort as the set order should be deterministic
already... this test uses `HashMap` which is non-determiistic so we need
`pickUnordedSet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
