dcapwell commented on code in PR #3779:
URL: https://github.com/apache/cassandra/pull/3779#discussion_r1932948935
##########
src/java/org/apache/cassandra/index/sai/plan/FilterTree.java:
##########
@@ -98,46 +96,78 @@ private boolean localSatisfiedBy(DecoratedKey key, Row row,
Row staticRow)
BooleanOperator localOperator = (isStrict ||
!context.hasUnrepairedMatches) ? baseOperator : BooleanOperator.OR;
boolean result = localOperator == BooleanOperator.AND;
- Iterator<ColumnMetadata> columnIterator =
expressions.keySet().iterator();
+ // If there are no unrepaired matches on indexed columns, we can't use
strict filtering, and there are multiple
+ // unindexed column expressions, isolate the expressions on unindexed
columns and union their results:
Review Comment:
we spoke in slack about this, maybe the below would be easier to read
```
// If all matches on indexed columns are repaired, strict filtering is not
allowed, and there are multiple
// unindexed column expressions, isolate the expressions on unindexed
columns and union their results:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
