dcapwell commented on code in PR #3842: URL: https://github.com/apache/cassandra/pull/3842#discussion_r1934190635
########## src/java/org/apache/cassandra/service/accord/FetchTopology.java: ########## @@ -37,6 +41,7 @@ public class FetchTopology { + private static final Logger log = LoggerFactory.getLogger(FetchTopology.class); Review Comment: nit, any reason not to use `logger`? ``` $ grep -r 'Logger log' src/ | awk -F: '{print $2}' | awk -F= '{print $1}' | sort | uniq -c | sort -k1,1 -h 1 Logger logBackLogger 1 Logger logbackLogger 1 private static Logger logger 1 public static void logInitializationOutcome(Logger logger) 1 private boolean hasAppenders(Logger logBackLogger) 1 private static Logger logger() 1 private static final Logger logger; 1 private static final org.slf4j.Logger logger 1 protected static final NoSpamLogger logger 1 public static <K, V> void dumpDiff(Logger logger, Map<K, V> l, Map<K, V> r) 1 public static Logger logger 1 public static NoSpamLogStatement getStatement(Logger logger, String message, long minInterval, TimeUnit unit) 1 public static NoSpamLogger getLogger(Logger logger, long minInterval, TimeUnit unit) 1 public static boolean log(Logger logger, Level level, String key, long minInterval, TimeUnit unit, String message, Object... objects) 1 public static boolean log(Logger logger, Level level, String key, long minInterval, TimeUnit unit, String message, Supplier<Object[]> objects) 1 public static boolean log(Logger logger, Level level, String key, long minInterval, TimeUnit unit, long nowNanos, String message, Object... objects) 1 public static boolean log(Logger logger, Level level, String key, long minInterval, TimeUnit unit, long nowNanos, String message, Supplier<Object[]> objects) 1 public static boolean log(Logger logger, Level level, long minInterval, TimeUnit unit, String message, Object... objects) 1 public static boolean log(Logger logger, Level level, long minInterval, TimeUnit unit, String message, Supplier<Object[]> objects) 1 public static void dumpDiff(Logger logger, Map<ReplicationParams, DataPlacement> l, Map<ReplicationParams, DataPlacement> r) 1 public static void logSystemInfo(Logger logger) 1 public void log(Logger log) 1 public void logRowCountPerLeaf(Logger logger) 1 public void logRowSizePerLeaf(Logger logger) 2 protected final static Logger logger 3 for (Logger logBackLogger 3 private final Logger logger 3 private static Logger logger 6 static final Logger logger 7 Logger logger 11 private final static Logger logger 19 private static final Logger logger 26 protected static final Logger logger 464 private static final Logger logger ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org