ifesdjeen commented on code in PR #3842:
URL: https://github.com/apache/cassandra/pull/3842#discussion_r1934374115
##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -420,14 +424,17 @@ void maybeReportMetadata(ClusterMetadata metadata)
@Override
protected void fetchTopologyInternal(long epoch)
{
+ if (ClusterMetadata.current().epoch.getEpoch() < epoch)
+
ClusterMetadataService.instance().fetchLogFromCMS(Epoch.create(epoch));
+
try
{
Set<InetAddressAndPort> peers = new
HashSet<>(ClusterMetadata.current().directory.allJoinedEndpoints());
peers.remove(FBUtilities.getBroadcastAddressAndPort());
if (peers.isEmpty())
return;
Topology topology;
- while ((topology
=FetchTopology.fetch(SharedContext.Global.instance, peers, epoch).get()) ==
null) {}
+ while ((topology =
FetchTopology.fetch(SharedContext.Global.instance, peers, epoch).get()) ==
null) {}
Review Comment:
Discussed in chat: intention for this was gap-filling. I agree that most
commonly this will actually never be used. Added logic right before that to
exit early if TCM has reported the metadata already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
