dcapwell commented on code in PR #3852:
URL: https://github.com/apache/cassandra/pull/3852#discussion_r1935990449


##########
test/distributed/org/apache/cassandra/distributed/test/accord/InteropTokenRangeTest.java:
##########
@@ -93,6 +93,10 @@ public void test() throws IOException
                     
Assertions.assertThat(tokens(node.executeWithResult(withKeyspace("SELECT * FROM 
%s.tbl WHERE " + op.condition), QUORUM, pk)))
                               .describedAs("Token %d with operator %s", token, 
op.condition)
                               .isEqualTo(op.expected(token, tokens));
+
+                    
Assertions.assertThat(tokens(node.executeWithPagingWithResult(withKeyspace("SELECT
 * FROM %s.tbl WHERE " + op.condition), QUORUM, 1, pk)))

Review Comment:
   for this patch i won't require this, but the other patch about token ranges 
returning wrong data likely should... we should likely do the same thing for 
the `ode.executeWithResult(withKeyspace("SELECT * FROM %s.tbl WHERE " + 
lt.condition + " AND " + gt.condition), QUORUM, pk, pk)` logic as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to