jahstreet commented on code in PR #2007:
URL:
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1936216042
##########
core/src/main/java/com/datastax/oss/driver/internal/core/metadata/InitialNodeListRefresh.java:
##########
@@ -63,22 +63,29 @@ public Result compute(
TokenFactory tokenFactory = null;
Map<UUID, DefaultNode> newNodes = new HashMap<>();
+ // Contact point nodes don't have host ID as well as other info yet, so we
fill them with node
+ // info found on first match by endpoint
+ Set<DefaultNode> matchedContactPoints = new HashSet<>();
Review Comment:
Pushed a commit to address the proposal, @adutra please take a look 🙏 .
I like it less, it requires adding `addedNodes` collection and down the line
we still rely on DefaultNode equality checks by reference, eg. in PoolManager.
But I'm also good to go as-is.
If you approve, I will squash the commits and add the required commit
description about the author and reviewers (linked it in the footer of the PR
description).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
