dcapwell commented on code in PR #3842:
URL: https://github.com/apache/cassandra/pull/3842#discussion_r1937731916
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -204,6 +205,14 @@ public MinEpochRetrySpec()
}
}
+ public static class FetchRetrySpec extends RetrySpec
Review Comment:
`RetrySpec` has the following constructor
```
public RetrySpec(MaxAttempt maxAttempts, LongMillisecondsBound
baseSleepTime, LongMillisecondsBound maxSleepTime)
```
Nothing stops us from adding
```
public RetrySpec(MaxAttempt maxAttempts)
```
or a `create` method... I think i did things this way mostly because of
repair but nothing is wrong with `RetrySpec fetchRetry =
RetrySpec.create(100);` IMO
I am 100% fine with this class (assuming the ref test is fixed), I am also
fine with creating new methods in `RetrySpec` to get the same behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
