dcapwell commented on code in PR #3864:
URL: https://github.com/apache/cassandra/pull/3864#discussion_r1940236589
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -1131,6 +1136,8 @@ else if (conditional instanceof Conditional.And)
boolean include(BytesPartitionState partition)
{
if (unmatchable) return false;
+ // did we include a bad partition?
+ if (partition.shouldDelete()) return false;
Review Comment:
correct. The fix is to do this on the write side, this is just extra
defensive; the write side is what actually matters.
The bug was that the partition was empty but had a static column with
values, but then we did a delete to that static column; this puts the partition
into `shouldDelete` but that code path didn't remove the partition. The `token
= token` logic found the partition and included, so added this check to be
extra defensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
