smiklosovic commented on code in PR #3868:
URL: https://github.com/apache/cassandra/pull/3868#discussion_r1942108229
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1480,24 +1480,28 @@ private static Pair<DiskAccessMode, Boolean>
resolveCommitLogWriteDiskAccessMode
{
boolean compressOrEncrypt = getCommitLogCompression() != null ||
(getEncryptionContext() != null && getEncryptionContext().isEnabled());
boolean directIOSupported = false;
- try
+ // File.getBlockSize creates directories/files tools may not have
permissions for
+ if (!toolInitialized)
Review Comment:
@jonmeredith can you just `return` when `toolInitialized` is true? Then we
do not need to have all that logic in `if`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
