belliottsmith commented on code in PR #3875:
URL: https://github.com/apache/cassandra/pull/3875#discussion_r1944796324
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -219,9 +219,9 @@ public boolean awaitTermination(long timeout, TimeUnit
units) throws Interrupted
}
@Override
- public Command loadCommand(int commandStoreId, TxnId txnId,
RedundantBefore redundantBefore, DurableBefore durableBefore)
+ public Command loadCommand(int store, TxnId txnId, RedundantBefore
redundantBefore, DurableBefore durableBefore)
Review Comment:
it would be nice to stick to consistent naming everywhere, and we mostly
refer to the referred objects as `commandStore`, and so `commandStoreId` is
most consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
