dcapwell commented on code in PR #3877:
URL: https://github.com/apache/cassandra/pull/3877#discussion_r1945588593
##########
test/distributed/org/apache/cassandra/fuzz/topology/AccordTopologyMixupTest.java:
##########
@@ -240,13 +225,52 @@ public String createSchema()
private static class AccordState extends State<Spec>
{
+ private final Map<Integer, String> instanceEpochReadyState = new
TreeMap<>();
+ private final Map<Integer, String> instanceEpochSyncState = new
TreeMap<>();
private final ListenerHolder listener;
public AccordState(RandomSource rs)
{
super(rs, AccordTopologyMixupTest::createSchemaSpec,
AccordTopologyMixupTest::cqlOperations);
this.listener = new ListenerHolder(this);
+ this.preActions.add(this::populateEpochState);
+ }
+
+ @Override
+ protected boolean allowRepair()
+ {
+ //TODO (required, operational): repair barriers depend on
durability sync, which requires ALL, even if --force is done.
+ return topologyHistory.down().length == 0;
Review Comment:
disable repair when there are downed nodes. We use `--force` but seeing
barriers complaining in the logs about not enough nodes
##########
test/distributed/org/apache/cassandra/fuzz/topology/HarryOnAccordTopologyMixupTest.java:
##########
@@ -71,6 +71,13 @@ public HarryOnAccordState(RandomSource rs)
this.listener = new ListenerHolder(this);
}
+ @Override
+ protected boolean allowRepair()
+ {
+ //TODO (required, operational): repair barriers depend on
durability sync, which requires ALL, even if --force is done.
+ return topologyHistory.down().length == 0;
Review Comment:
disable repair when there are downed nodes. We use `--force` but seeing
barriers complaining in the logs about not enough nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
