jameshartig commented on code in PR #1837:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1837#discussion_r1945907796
##########
frame.go:
##########
@@ -275,39 +292,15 @@ func ParseConsistencyWrapper(s string) (consistency
Consistency, err error) {
return
}
-type SerialConsistency uint16
-
-const (
- Serial SerialConsistency = 0x08
- LocalSerial SerialConsistency = 0x09
-)
-
-func (s SerialConsistency) String() string {
- switch s {
- case Serial:
- return "SERIAL"
- case LocalSerial:
- return "LOCAL_SERIAL"
- default:
- return fmt.Sprintf("UNKNOWN_SERIAL_CONS_0x%x", uint16(s))
- }
-}
-
-func (s SerialConsistency) MarshalText() (text []byte, err error) {
- return []byte(s.String()), nil
-}
-
-func (s *SerialConsistency) UnmarshalText(text []byte) error {
- switch string(text) {
- case "SERIAL":
- *s = Serial
- case "LOCAL_SERIAL":
- *s = LocalSerial
- default:
- return fmt.Errorf("invalid consistency %q", string(text))
+// MustParseConsistency is the same as ParseConsistency except it returns
Review Comment:
We shouldn't be adding this back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
