yifan-c commented on code in PR #176:
URL: https://github.com/apache/cassandra-sidecar/pull/176#discussion_r1949701986


##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/response/GossipInfoResponse.java:
##########
@@ -275,7 +282,8 @@ protected enum GossipField
          * as a comma-separated list.
          **/
         SSTABLE_VERSIONS,
-        DISK_USAGE;
+        DISK_USAGE,
+        INDEX_STATUS;

Review Comment:
   Add a comment to indicate since what Cassandra verison the gossip value is 
available.
   And move `;` to a new line, to avoid showing the diff on the existing enum 
in the future. 
   
   I can also update it on merging, if you agree with the suggestion, but do 
not feel like to push a new commit. 
   
   ```suggestion
           INDEX_STATUS, // Intorduced in Cassandra 5.0 for SAI 
           ;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to