bereng commented on code in PR #3883:
URL: https://github.com/apache/cassandra/pull/3883#discussion_r1950394256
##########
src/java/org/apache/cassandra/repair/consistent/LocalSessions.java:
##########
@@ -1021,6 +1021,7 @@ public void handleStatusResponse(InetAddressAndPort from,
StatusResponse respons
}
else
{
+ session.setLastUpdate();
logger.debug("Received StatusResponse for repair session {} with
state {}, which is not actionable. Doing nothing.", sessionID, response.state);
Review Comment:
I think icwym. You're probably referring to the junit being named 'noop'? It
depends a lot on how you parse that in your brain imo. I read it as it's noop
in terms of the status of the repair, which doesn't change. You probably read
it as a pure 100% noop whereas now we're updating a timestamp? Some other
people read junits as a pseudo-doc of the expected behavior of what a noop
status operation should do :shrug: I think we're good and we avoid adding an
extra almost identical test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
