belliottsmith commented on code in PR #168:
URL: https://github.com/apache/cassandra-accord/pull/168#discussion_r1954104094
##########
accord-core/src/main/java/accord/coordinate/CollectLatestDeps.java:
##########
@@ -95,10 +109,15 @@ public void onFailure(Id from, Throwable failure)
if (isDone)
return;
+ if (failure != null)
+ this.failure = FailureAccumulator.append(this.failure, failure);
+
if (tracker.recordFailure(from) == Failed)
{
isDone = true;
- callback.accept(null, new Timeout(txnId, route.homeKey()));
+ if (this.failure == null)
Review Comment:
We don't really distinguish between Timeout and having exhausted our options
in most places. We do technically have `Exhausted`, I can switch to that if you
like? It is probably more correct. We should at some point go through all our
exception logic and make sure it is consistent, I noticed already a number of
inconsistencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
