rtib commented on code in PR #3905:
URL: https://github.com/apache/cassandra/pull/3905#discussion_r1959132200
##########
src/java/org/apache/cassandra/db/virtual/VirtualKeyspaceRegistry.java:
##########
@@ -73,6 +76,11 @@ public TableMetadata getTableMetadataNullable(TableId id)
return null != table ? table.metadata() : null;
}
+ public ImmutableSet<String> getKeyspaces()
Review Comment:
Where do you want to put that method? It should be a class covering all
keyspaces, virtual and storage backed as well. AFAIK we don't have such a
class. We have the Schema class covering storage backed keyspaces only and we
have this class in a similar role for virtual keyspaces. The semantics of
`VirtualKeyspaceRegistry.isVirtualKeyspace(String)` reads a bit strange to me.
Rather, there could be an `exists(String)` method in both classes.
The idea was, adding this method analogous to the interface of the Schema
class, so that accessing the set of virtual keyspaces is similar to accessing
storage backed keyspaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
