yifan-c commented on code in PR #198:
URL: https://github.com/apache/cassandra-sidecar/pull/198#discussion_r1964068967
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/authorization/BasicPermissions.java:
##########
@@ -63,6 +63,9 @@ public class BasicPermissions
public static final Permission READ_OPERATIONAL_JOB = new
DomainAwarePermission("OPERATIONAL_JOB:READ", OPERATION_SCOPE);
public static final Permission DECOMMISSION_NODE = new
DomainAwarePermission("NODE:DECOMMISSION", OPERATION_SCOPE);
+ // Permissions related to Schema Reporting
+ public static final Permission REPORT_SCHEMA = new
DomainAwarePermission("SCHEMA:REPORT", CLUSTER_SCOPE);
Review Comment:
The sentiment here is to have restraint in adding new verbs. Ideally, it
should be a fixed set of verb to avoid operational pain.
The reason that READ should work here is that the reporter is reading the
cassandra schema. When it publishes (i.e. sends requests to DataHub), the
authorization should be enforced by the server (DataHub), not the client
(Sidecar).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
