frankgh commented on code in PR #193:
URL: https://github.com/apache/cassandra-sidecar/pull/193#discussion_r1964382410
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##########
@@ -121,6 +121,12 @@ public final class ApiEndpointsV1
public static final String LIST_CDC_SEGMENTS_ROUTE = API_V1 + CDC_PATH +
"/segments";
public static final String STREAM_CDC_SEGMENTS_ROUTE =
LIST_CDC_SEGMENTS_ROUTE + "/" + SEGMENT_PATH_PARAM;
+ public static final String SERVICES_PATH = "/services";
+ public static final String SERVICE_PARAM = ":service";
+ public static final String CONFIG = "/config";
+ public static final String SERVICE_CONFIG_ROUTE = API_V1 + SERVICES_PATH +
SERVICE_PARAM + CONFIG;
+ public static final String GET_SERVICES_CONFIG_ROUTE = API_V1 +
SERVICES_PATH;
Review Comment:
I think the URI should be the same for the service, with different verbs to
specify the action:
`/api/v1/config/services/:service`
- GET : retrieve configuration for :service
- DELETE: remove configuration for :service
- PUT: update configuration for :service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
