belliottsmith commented on code in PR #173:
URL: https://github.com/apache/cassandra-accord/pull/173#discussion_r1968447777
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -554,15 +556,18 @@ public static void listenerUpdate(SafeCommandStore
safeStore, SafeCommand safeLi
}
}
- protected static void postApply(SafeCommandStore safeStore, Command
command)
+ protected static boolean postApply(SafeCommandStore safeStore, TxnId
txnId, long t0)
Review Comment:
I think I previously was using the boolean to decide whether to invoke the
metric callback in the caller, but decided to move it inside the method instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
