smiklosovic commented on code in PR #3907: URL: https://github.com/apache/cassandra/pull/3907#discussion_r1971838035
########## src/java/org/apache/cassandra/cql3/constraints/OctetLengthConstraint.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.constraints; + +import java.nio.ByteBuffer; + +import org.apache.cassandra.cql3.ColumnIdentifier; +import org.apache.cassandra.cql3.Operator; +import org.apache.cassandra.db.marshal.AbstractType; +import org.apache.cassandra.db.marshal.AsciiType; +import org.apache.cassandra.db.marshal.BytesType; +import org.apache.cassandra.db.marshal.Int32Type; +import org.apache.cassandra.db.marshal.UTF8Type; +import org.apache.cassandra.schema.ColumnMetadata; +import org.apache.cassandra.utils.ByteBufferUtil; + +public class OctetLengthConstraint extends ConstraintFunction +{ + private static final AbstractType<?>[] SUPPORTED_TYPES = new AbstractType[] { BytesType.instance, UTF8Type.instance, AsciiType.instance }; + + public OctetLengthConstraint(ColumnIdentifier columnName) + { + super(columnName, "OCTET_LENGTH"); + } + + @Override + public void internalEvaluate(AbstractType<?> valueType, Operator relationType, String term, ByteBuffer columnValue) + { + int valueLength = getValueSize(columnValue); + int sizeConstraint = Integer.parseInt(term); + + ByteBuffer leftOperand = ByteBufferUtil.bytes(valueLength); + ByteBuffer rightOperand = ByteBufferUtil.bytes(sizeConstraint); + + if (!relationType.isSatisfiedBy(Int32Type.instance, leftOperand, rightOperand)) + throw new ConstraintViolationException("Column value does not satisfy value constraint for column '" + columnName + "'. " + + "It has a length of " + valueLength + " and it should be should be " + + relationType + ' ' + term); + } + + @Override + public void validate(ColumnMetadata columnMetadata) + { + boolean supported = false; + AbstractType<?> unwrapped = columnMetadata.type.unwrap(); + for (AbstractType<?> supportedType : SUPPORTED_TYPES) + { + if (supportedType == unwrapped) + { + supported = true; + break; + } + } + + if (!supported) + throw invalidConstraintDefinitionException(columnMetadata.type); + } + + private int getValueSize(ByteBuffer value) + { + return value.remaining(); + } + + private InvalidConstraintDefinitionException invalidConstraintDefinitionException(AbstractType<?> valueType) Review Comment: same, just inline it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
