yifan-c commented on code in PR #200: URL: https://github.com/apache/cassandra-sidecar/pull/200#discussion_r1980450219
########## server/src/main/java/org/apache/cassandra/sidecar/modules/SidecarModules.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.modules; + +import java.nio.file.Path; +import java.util.List; + +import com.google.inject.Module; +import com.google.inject.util.Modules; +import org.apache.cassandra.sidecar.modules.multibindings.MultiBindingTypeResolverModule; +import org.jetbrains.annotations.Nullable; + +/** + * Collection of sidecar modules + */ +public class SidecarModules +{ + private SidecarModules() + { + throw new UnsupportedOperationException(); + } + + /** + * All sidecar modules + * @param confPath path to the configuration file + * @return all sidecar modules + */ + public static List<Module> all(@Nullable Path confPath) + { + // To prevent unexpected circular dependency chains in your code, we recommend that you disable Guice's circular proxy feature. + return List.of(Modules.disableCircularProxiesModule(), + new ApiModule(), + new AuthModule(), + new CassandraOperationsModule(), + new CdcModule(), + new ConfigurationModule(confPath), Review Comment: For this PR, I would like to stick to the idea of group bindings by feature. VertxSetup is not a feature. Btw, the order of the modules in the list does not affect bindings. They are just sorted alphabetically to look neat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
