smiklosovic commented on code in PR #3939: URL: https://github.com/apache/cassandra/pull/3939#discussion_r1981399136
########## test/distributed/org/apache/cassandra/distributed/upgrade/CompressionUpgradeTest.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.distributed.upgrade; + +import org.junit.Test; + +import org.apache.cassandra.io.compress.DeflateCompressor; +import org.apache.cassandra.io.compress.LZ4Compressor; +import org.apache.cassandra.io.compress.SnappyCompressor; +import org.apache.cassandra.io.compress.ZstdCompressor; + +import static java.lang.String.format; +import static org.apache.cassandra.distributed.api.ConsistencyLevel.ALL; +import static org.apache.cassandra.distributed.api.Feature.GOSSIP; +import static org.apache.cassandra.distributed.api.Feature.NETWORK; +import static org.apache.cassandra.distributed.shared.AssertUtils.assertRows; +import static org.apache.cassandra.distributed.shared.AssertUtils.row; + +public class CompressionUpgradeTest extends UpgradeTestBase +{ + @Test + public void testCompressors() throws Throwable + { + String[][] zstdQueries = forZstd(); + run(new String[][]{ + zstdQueries[0], // min + zstdQueries[1], // default + zstdQueries[2], // max + forCompressor(SnappyCompressor.class), + forCompressor(DeflateCompressor.class), + forCompressor(LZ4Compressor.class) + }); + } + + private String[][] forZstd() + { + String tableTemplate = "CREATE TABLE %s.%s (pk int, ck int, v int, PRIMARY KEY (pk, ck)) WITH compression = {'class': '" + ZstdCompressor.class.getSimpleName() + "', 'compression_level': %s}"; + String insertTemplate = "INSERT INTO %s.%s (pk, ck, v) VALUES (1, 1, 1)"; + String selectTemplate = "SELECT * FROM %s.%s WHERE pk = 1"; + + // Zstd min and max compression levels, (Zstd.{min,default,max}CompressionLevel()) + // It should be possible to create a table with this level in each version and read / write data with it + String[][] params = new String[][]{ { "tbl_zstd_min_compression_level", Integer.toString(-131072) }, + { "tbl_zstd_max_compression_level", Integer.toString(22) }, + { "tbl_zstd_default_compression_level", Integer.toString(3) } }; + + String[][] zstdQueries = new String[params.length][params.length]; + + for (int i = 0; i < params.length; i++) + { + zstdQueries[i][0] = format(tableTemplate, KEYSPACE, params[i][0], params[i][1]); + zstdQueries[i][1] = format(insertTemplate, KEYSPACE, params[i][0]); + zstdQueries[i][2] = format(selectTemplate, KEYSPACE, params[i][0]); + } + + return zstdQueries; + } + + private String[] forCompressor(Class<?> compressorClass) + { + String compressorName = compressorClass.getSimpleName(); + return new String[]{ + "CREATE TABLE " + KEYSPACE + ".tbl_" + compressorName + " (pk int, ck int, v int, PRIMARY KEY (pk, ck)) WITH compression = {'class': '" + compressorName + "'}", + "INSERT INTO " + KEYSPACE + ".tbl_" + compressorName + " (pk, ck, v) VALUES (1, 1, 1)", + "SELECT * FROM " + KEYSPACE + ".tbl_" + compressorName + " WHERE pk = 1" + }; + } + + private void run(String[][] queries) throws Throwable + { + new TestCase() + .nodes(2) + .nodesToUpgrade(1) + .withConfig((cfg) -> cfg.with(NETWORK, GOSSIP)) + .upgradesToCurrentFrom(OLDEST) + .setup((cluster) -> { + for (int i = 0; i < queries.length; i++) + { + cluster.schemaChange(queries[i][0]); + cluster.coordinator(1).execute(queries[i][1], ALL); + } + }) + .runAfterNodeUpgrade((cluster, node) -> { + for (int i : new int[]{ 1, 2 }) + for (int j = 0; j < queries.length; j++) + assertRows(cluster.coordinator(i).execute(queries[j][2], ALL), row(1, 1, 1)); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
