tiagomlalves commented on code in PR #3931: URL: https://github.com/apache/cassandra/pull/3931#discussion_r1987806627
########## test/unit/org/apache/cassandra/config/ParameterizedClassExample.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.config; + +import java.util.Map; + +import org.junit.Assert; + +public class ParameterizedClassExample Review Comment: @smiklosovic I've started with that approach and it didn't work. I should have documented this somewhere (e.g commit) - sorry about that. When using an inner class the outer class is added as first argument of the constructor. Our logic (and the original one) expects that we have exactly either no arguments or a single argument of type `Map` which rules out the usage of inner classes for auth*. So, at least this is not a regression on the original behavior. There might be another way to do that - I don't know enough of Java internals to propose such solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
