Maxwell-Guo commented on code in PR #3969:
URL: https://github.com/apache/cassandra/pull/3969#discussion_r1990501090
##########
pylib/cqlshlib/cql3handling.py:
##########
@@ -328,8 +328,14 @@ def dequote_value(cqlword):
;
<constraint> ::= <cident> <cmp> <term>
- | <functionArguments> <cmp> <term>
+ | <constraintFunction> <functionArguments> <cmp> <term>
;
+
+<constraintFunction> ::= "LENGTH"
Review Comment:
Is it possible to divide functions into two categories, one that can be used
with <cmp> and one that cannot? It seems that this can achieve the above goal
of refining categories.
##########
pylib/cqlshlib/cql3handling.py:
##########
@@ -328,8 +328,14 @@ def dequote_value(cqlword):
;
<constraint> ::= <cident> <cmp> <term>
- | <functionArguments> <cmp> <term>
+ | <constraintFunction> <functionArguments> <cmp> <term>
Review Comment:
Is it possible to refine each function ?
for example : LENGTH can be followed by cmp but JSON can not, as long as
NOT_NULL，
but every time I type any function name, it is followed by a <cmp> prompt,
which actually gives users some misunderstandings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
