5 commented on code in PR #205:
URL: https://github.com/apache/cassandra-sidecar/pull/205#discussion_r1996232965
##########
server/src/main/java/org/apache/cassandra/sidecar/datahub/SchemaReportingTask.java:
##########
@@ -94,17 +97,34 @@ public DurationSpec delay()
}
@Override
- public void execute(Promise<Void> promise)
+ public void execute(@NotNull Promise<Void> promise)
+ {
+ execute(promise, 1);
+ }
+
+ protected void execute(@NotNull Promise<Void> promise,
+ int attempt)
{
try
{
+ LOGGER.info("Schema report has been triggered by the schedule");
reporter.process(session.get().getCluster());
Review Comment:
Done.
##########
server/src/main/java/org/apache/cassandra/sidecar/datahub/SchemaReportingTask.java:
##########
@@ -94,17 +97,34 @@ public DurationSpec delay()
}
@Override
- public void execute(Promise<Void> promise)
+ public void execute(@NotNull Promise<Void> promise)
+ {
+ execute(promise, 1);
+ }
+
+ protected void execute(@NotNull Promise<Void> promise,
+ int attempt)
{
try
{
+ LOGGER.info("Schema report has been triggered by the schedule");
reporter.process(session.get().getCluster());
promise.complete();
}
catch (Throwable throwable)
{
- LOGGER.error("Failed to convert and report the current schema",
throwable);
- promise.fail(throwable);
+ if (attempt < configuration.retries())
+ {
+ LOGGER.warn("Schema report has failed and will be retried
soon", throwable);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
