dcapwell commented on code in PR #182: URL: https://github.com/apache/cassandra-accord/pull/182#discussion_r1996445272
########## accord-core/src/main/java/accord/primitives/Keys.java: ########## @@ -94,7 +94,10 @@ public Keys slice(Ranges ranges, Slice slice) @Override public final boolean containsAll(AbstractUnseekableKeys that) { - return that.size() == SortedArrays.foldlIntersection(0, RoutableKey::compareAsRoutingKey, that.keys, 0, that.keys.length, keys, 0, keys.length, (k, p, v, l, r) -> v + 1, 0, 0, 0); + return that.size() == SortedArrays.foldlIntersection(0, RoutableKey::compareAsRoutingKey, + keys, 0, keys.length, + that.keys, 0, that.keys.length, Review Comment: swapped keys and that.keys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org