yifan-c commented on code in PR #209:
URL: https://github.com/apache/cassandra-sidecar/pull/209#discussion_r1997480063
##########
integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##########
@@ -562,6 +534,25 @@ public static Cluster createDriverCluster(ICluster<?
extends IInstance> dtest)
return builder.build();
}
+ /**
+ * Wraps the Sidecar server and keeps a reference to the injector to be
able to dynamically retrieve
+ * objects for testing purposes
+ */
+ public static class ServerWrapper
+ {
+ public final Injector injector;
+ public final Server server;
+ public volatile int serverPort;
Review Comment:
Why not expose a _method_ for port that is sourcing from `server`? Thus,
updating the int field is avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
