absurdfarce commented on code in PR #108: URL: https://github.com/apache/cassandra-builds/pull/108#discussion_r1999177366
########## docker/testing/ubuntu2204_java_driver_testing.docker: ########## @@ -38,12 +38,14 @@ RUN export JABBA_HOME="$HOME/.jabba" && \ RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.8.0-292 RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.11.0-9 RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@17 +RUN . /home/docker/.jabba/jabba.sh && jabba install openjdk@1.21.0 Review Comment: It seems a little weird to go from the major-version only "openjdk@17" to the more precise "openjdk@1.21.0", especially since we were using the more precise variant for every JDK version above us. Perhaps we want to change "openjdk@17" to something specifying a minor and patch version as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
