frankgh commented on code in PR #211:
URL: https://github.com/apache/cassandra-sidecar/pull/211#discussion_r2004459240
##########
server/src/test/integration/org/apache/cassandra/sidecar/coordination/MostReplicatedKeyspaceTokenZeroElectorateMembershipIntegrationTest.java:
##########
@@ -107,12 +109,17 @@ void test(TestVersion version) throws IOException
private void runTestScenario(AbstractCluster<?> cluster)
{
- List<MostReplicatedKeyspaceTokenZeroElectorateMembership> memberships
= buildElectorateMembershipPerCassandraInstance(cluster);
+ var pair = buildElectorateMembershipPerCassandraInstance(cluster);
Review Comment:
I used it for convenience in the test, otherwise the line was huge! I'd
prefer to keep it here, but I also am wary of introducing var because other
contributors will start using it and I think we should lean on discouraging its
use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
