dcapwell commented on code in PR #4006: URL: https://github.com/apache/cassandra/pull/4006#discussion_r2010676271
########## test/unit/org/apache/cassandra/cql3/ast/Mutation.java: ########## @@ -404,9 +419,20 @@ public Statement visit(Visitor v) Conditional copiedWhere = where.visit(v); if (where != copiedWhere) updated = true; + Optional<? extends CasCondition> updatedCasCondition = casCondition; + if (casCondition.isPresent()) Review Comment: this was missed with the first round of `visit` impl. The side effect was mostly for the human readable `History:` dump when we find mismatches, as that would show a `?` rather than the CQL literal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org