smiklosovic commented on code in PR #4011:
URL: https://github.com/apache/cassandra/pull/4011#discussion_r2015780797
##########
src/java/org/apache/cassandra/tools/nodetool/stats/GcStatsHolder.java:
##########
@@ -19,20 +19,48 @@
package org.apache.cassandra.tools.nodetool.stats;
import java.util.HashMap;
+import java.util.LinkedHashMap;
import java.util.Map;
import org.apache.cassandra.tools.NodeProbe;
+import static org.apache.cassandra.io.util.FileUtils.stringifyFileSize;
+
/**
* Holds and converts GC statistics to a map structure.
*/
public class GcStatsHolder implements StatsHolder
{
- public final NodeProbe probe;
+ public static final String INTERVAL = "interval_ms";
+ public static final String MAX_GC = "max_gc_elapsed_ms";
+ public static final String TOTAL_GC = "total_gc_elapsed_ms";
+ public static final String STDEV_GC = "stdev_gc_elapsed_ms";
+ public static final String RECLAIMED_GC = "gc_reclaimed_mb";
+ public static final String COLLECTIONS = "collections";
Review Comment:
there are no units, it is simply number of gc collections since the time the
command was executed last time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
