smiklosovic commented on code in PR #4021:
URL: https://github.com/apache/cassandra/pull/4021#discussion_r2020931408
##########
src/java/org/apache/cassandra/hints/HintVerbHandler.java:
##########
@@ -101,7 +102,16 @@ else if
(!StorageProxy.instance.appliesLocally(hint.mutation))
else
{
// the common path - the node is both the destination and a valid
replica for the hint.
- hint.applyFuture().addCallback(o -> respond(message), e ->
logger.debug("Failed to apply hint", e));
+ hint.applyFuture().addCallback(
+ o -> {
+ HintsServiceMetrics.hintsApplySucceeded.mark();
Review Comment:
@maoling can we do this _after_ we do `respond(message)`? What if
`respond(message)` fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
