dcapwell commented on code in PR #4044:
URL: https://github.com/apache/cassandra/pull/4044#discussion_r2027944078
##########
test/harry/main/org/apache/cassandra/harry/model/PartitionState.java:
##########
@@ -236,8 +236,12 @@ private RowState updateRowState(RowState currentState,
IntFunction<Bijections.Bi
{
// Timestamp collision case
Bijections.Bijection<?> column = columns.apply(i);
- if (column.compare(vds[i], currentState.vds[i]) > 0)
+ if (vds[i] == MagicConstants.NIL_DESCR // writing a null
is the same as a tombstone, which has higher priority
Review Comment:
this would NPE if the value is a tombstone or you try to write one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
