dcapwell commented on code in PR #4049:
URL: https://github.com/apache/cassandra/pull/4049#discussion_r2029466914
##########
src/java/org/apache/cassandra/tcm/migration/CMSInitializationRequest.java:
##########
@@ -109,12 +109,12 @@ public long serializedSize(CMSInitializationRequest t,
int version)
public static class Initiator
{
public static final Serializer serializer = new Serializer();
- public final InetAddressAndPort initiator;
+ public final InetAddressAndPort endpoint;
Review Comment:
can we annotate `@Nullable`? Its null here
`org.apache.cassandra.tcm.migration.Election#MIGRATING`
##########
src/java/org/apache/cassandra/tcm/migration/CMSInitializationRequest.java:
##########
@@ -109,12 +109,12 @@ public long serializedSize(CMSInitializationRequest t,
int version)
public static class Initiator
{
public static final Serializer serializer = new Serializer();
- public final InetAddressAndPort initiator;
+ public final InetAddressAndPort endpoint;
public final UUID initToken;
Review Comment:
can we annotate `@Nullable`? Its null here
`org.apache.cassandra.tcm.migration.Election#MIGRATING`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
