jmckenzie-dev commented on code in PR #4030:
URL: https://github.com/apache/cassandra/pull/4030#discussion_r2025500938
##########
src/java/org/apache/cassandra/batchlog/BatchlogManager.java:
##########
@@ -548,18 +548,25 @@ private static class ReplayWriteResponseHandler<T>
extends WriteResponseHandler<
}
@Override
- protected int blockFor()
+ public int blockFor()
{
return this.replicaPlan.contacts().size();
}
@Override
public void onResponse(Message<T> m)
{
+ // tracker update handled in super
boolean removed = undelivered.remove(m == null ?
FBUtilities.getBroadcastAddressAndPort() : m.from());
assert removed;
super.onResponse(m);
}
+
+ @Override
+ public boolean receivedSufficientResponses()
+ {
+ return super.receivedSufficientResponses();
+ }
Review Comment:
I _was_ at one point (tracing to ensure things hit what they were supposed
to) but this is vestigial; removing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
