smiklosovic commented on code in PR #3994:
URL: https://github.com/apache/cassandra/pull/3994#discussion_r2003589668
##########
src/java/org/apache/cassandra/cql3/constraints/ScalarColumnConstraint.java:
##########
@@ -130,6 +125,15 @@ protected void internalEvaluate(AbstractType<?> valueType,
ByteBuffer columnValu
public void validate(ColumnMetadata columnMetadata) throws
InvalidConstraintDefinitionException
{
validateTypes(columnMetadata);
+
+ try
+ {
+ value = columnMetadata.type.fromString(term);
+ }
+ catch (Throwable t)
+ {
+ throw new ConstraintViolationException("Cannot parse constraint
value from '" + term + "' for column '" + columnName + '\'');
Review Comment:
we should test something like this:
````
cassandra@cqlsh> ALTER TABLE ks.my_times ALTER col CHECK col > '-1:00:00';
... [Invalid query] message="Cannot parse constraint value from '-1:00:00'
for column 'col'"
````
##########
src/java/org/apache/cassandra/cql3/constraints/ScalarColumnConstraint.java:
##########
@@ -130,6 +125,15 @@ protected void internalEvaluate(AbstractType<?> valueType,
ByteBuffer columnValu
public void validate(ColumnMetadata columnMetadata) throws
InvalidConstraintDefinitionException
{
validateTypes(columnMetadata);
+
+ try
+ {
+ value = columnMetadata.type.fromString(term);
+ }
+ catch (Throwable t)
+ {
+ throw new ConstraintViolationException("Cannot parse constraint
value from '" + term + "' for column '" + columnName + '\'');
Review Comment:
@bbotella
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
